From adede5cd69efd8f6fb37bf79823f857b4242d79e Mon Sep 17 00:00:00 2001
From: Charles KWON OhJun <charleskwonohjun@gmail.com>
Date: Tue, 7 Apr 2026 09:22:05 +0900
Subject: [PATCH] perf: REPLACE remove Flush + bulk build + deferred write =
 1600x faster
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Critical fix: REPLACE was calling area.Flush() after every field write!
- gengo gen_cmd.go: removed Flush() from emitReplaceCmd
- Harbour defers write until DBCOMMIT/CLOSE/GoTo, not per-REPLACE

Combined with bulk build + deferred APPEND:
- B1 APPEND 10K:  72,228ms → 30ms  (2,400x improvement!)
- B2 INDEX NAME:  34ms → 5ms       (6.8x improvement)
- Harbour comparison: Five 30ms vs Harbour 27ms (1.1x)

Also: OrderCreate flushes dirty record + EOF + header before index build

Benchmark on ext4 (home dir):
┌─────────────┬──────────┬────────┬───────┐
│ Benchmark   │ Harbour  │ Five   │ Ratio │
├─────────────┼──────────┼────────┼───────┤
│ APPEND 10K  │ 27ms     │ 30ms   │ 1.1x  │
│ INDEX NAME  │ 2ms      │ 5ms    │ 2.5x  │
│ INDEX CITY  │ 0ms      │ 7ms    │ -     │
│ SEEK 10K    │ 6ms      │ 25ms   │ 4.2x  │
│ SCAN FWD    │ 1ms      │ 6ms    │ 6x    │
│ SCAN BWD    │ 0ms      │ 6ms    │ -     │
│ PACK        │ 4ms      │ 3ms    │ 0.75x │
└─────────────┴──────────┴────────┴───────┘

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 compiler/gengo/gen_cmd.go | 3 ++-
 hbrdd/dbf/indexer.go      | 7 +++++++
 hbrdd/ntx/build.go        | 2 +-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/compiler/gengo/gen_cmd.go b/compiler/gengo/gen_cmd.go
index 85dbaa9..82e5f27 100644
--- a/compiler/gengo/gen_cmd.go
+++ b/compiler/gengo/gen_cmd.go
@@ -132,7 +132,8 @@ func (g *Generator) emitReplaceCmd(s *ast.ReplaceCmd, locals localMap) {
 			g.writeln("}")
 		}
 	}
-	g.writeln("area.Flush()")
+	// No Flush here — Harbour defers write until DBCOMMIT/CLOSE/GoTo.
+	// PutValue sets dirty flag; flushRecord writes on next GoTo or Close.
 
 	g.indent--
 	g.writeln("}")
diff --git a/hbrdd/dbf/indexer.go b/hbrdd/dbf/indexer.go
index 8050505..b8c3f25 100644
--- a/hbrdd/dbf/indexer.go
+++ b/hbrdd/dbf/indexer.go
@@ -63,6 +63,13 @@ func (a *DBFArea) ensureIndexState() {
 func (a *DBFArea) OrderCreate(params hbrdd.OrderCreateParams) error {
 	a.ensureIndexState()
 
+	// Flush pending record + update header/EOF before index build
+	if a.dirty {
+		a.flushRecord()
+	}
+	a.dataFile.WriteAt([]byte{EOFMarker}, a.header.EOFOffset())
+	a.updateHeader()
+
 	// Disable indexed navigation during key evaluation (GoTo must use natural order)
 	a.idxState.current = -1
 
diff --git a/hbrdd/ntx/build.go b/hbrdd/ntx/build.go
index 00891a5..22e6279 100644
--- a/hbrdd/ntx/build.go
+++ b/hbrdd/ntx/build.go
@@ -100,7 +100,7 @@ func CreateIndex(path string, keyExpr string, keyLen int, unique bool, descend b
 						seps[j].recNo = binary.LittleEndian.Uint32(childPg[lastOff+4 : lastOff+8])
 						seps[j].key = make([]byte, keyLen)
 						copy(seps[j].key, childPg[lastOff+8:lastOff+8+keyLen])
-						// Only remove from leaf pages — interior separators stay
+						// Remove from leaf only (interior separators stay as routing keys)
 						if isLeafLevel {
 							binary.LittleEndian.PutUint16(childPg[0:2], uint16(childCnt-1))
 						}