fivedev/five
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Phase 2 — HIGH #6,9,10,11,12,19,23,32,46,47

Browse Source 
Files modified (5):
  compiler/gengo/gengo.go — #6,#32: Deduplicate 3 Generate functions into 1
    doGenerate(file, debug, library) replaces 170 lines of copy-paste
    Dead GenerateDebug method removed
  cmd/five/main.go — #9,10,11,12: Fix 5 silently ignored errors
    filepath.Abs, tidy.Run, tidyCmd.CombinedOutput now checked
  hbrtl/strings.go — #19: Str() now reads caller's nWidth/nDec params
    Was ignoring explicit Str(123, 10, 2) arguments
  compiler/pp/pp.go — #46: Fix stale "NOT implemented" comment
    #47: Extract maxIncludeDepth constant
  compiler/lexer/lexer.go — #23: Remove unused LookupKeyword result

Issues resolved: 10 (HIGH: 7, MEDIUM: 3)
Total fixed: 26/53

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Charles KWON OhJun
2026-04-01 11:47:26 +09:00
parent 207fa9f7dd
commit f950cb0784
5 changed files with 115 additions and 135 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
docs/.pdca-status.json
View File

@@ -1,6 +1,6 @@
{
"version": "2.0",
"lastUpdated": "2026-04-01T01:50:29.561Z",
"lastUpdated": "2026-04-01T02:46:45.142Z",
"activeFeatures": [
"hbrt",
"hbrtl",
@@ -46,9 +46,9 @@
"documents": {},
"timestamps": {
"started": "2026-03-27T11:15:10.675Z",
"lastUpdated": "2026-04-01T01:16:33.700Z"
"lastUpdated": "2026-04-01T02:36:49.307Z"
},
"lastFile": "/mnt/d/charles/five/hbrtl/register.go"
"lastFile": "/mnt/d/charles/five/hbrtl/strings.go"
},
"tests": {
"phase": "do",
@@ -85,7 +85,7 @@
"documents": {},
"timestamps": {
"started": "2026-03-27T11:24:36.853Z",
"lastUpdated": "2026-03-30T15:46:43.429Z"
"lastUpdated": "2026-04-01T02:32:31.594Z"
},
"lastFile": "/mnt/d/charles/five/compiler/lexer/lexer.go"
},
@@ -124,7 +124,7 @@
"documents": {},
"timestamps": {
"started": "2026-03-27T11:45:21.266Z",
"lastUpdated": "2026-03-30T15:35:58.397Z"
"lastUpdated": "2026-04-01T02:46:45.142Z"
},
"lastFile": "/mnt/d/charles/five/compiler/gengo/gengo.go"
},
@@ -137,7 +137,7 @@
"documents": {},
"timestamps": {
"started": "2026-03-27T11:50:31.420Z",
"lastUpdated": "2026-04-01T01:27:55.511Z"
"lastUpdated": "2026-04-01T02:43:37.339Z"
},
"lastFile": "/mnt/d/charles/five/cmd/five/main.go"
},
@@ -202,7 +202,7 @@
"documents": {},
"timestamps": {
"started": "2026-03-27T23:11:55.802Z",
"lastUpdated": "2026-03-30T13:03:57.551Z"
"lastUpdated": "2026-04-01T02:35:12.240Z"
},
"lastFile": "/mnt/d/charles/five/compiler/pp/pp.go"
},
@@ -280,7 +280,7 @@
"session": {
"startedAt": "2026-03-27T06:06:49.620Z",
"onboardingCompleted": false,
"lastActivity": "2026-04-01T01:50:29.561Z"
"lastActivity": "2026-04-01T02:46:45.142Z"
},
"history": [
{
@@ -5628,6 +5628,72 @@
"feature": "hbrt",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:32:31.594Z",
"feature": "lexer",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:34:45.039Z",
"feature": "pp",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:35:12.240Z",
"feature": "pp",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:36:49.307Z",
"feature": "hbrtl",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:39:29.824Z",
"feature": "gengo",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:41:45.871Z",
"feature": "five",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:42:23.943Z",
"feature": "five",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:42:49.102Z",
"feature": "five",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:43:37.339Z",
"feature": "five",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:44:43.098Z",
"feature": "gengo",
"phase": "do",
"action": "updated"
},
{
"timestamp": "2026-04-01T02:46:45.142Z",
"feature": "gengo",
"phase": "do",
"action": "updated"
}
]
}