fivedev/five - five - fivego gitea

Author SHA1 Message Date

Author	SHA1	Message	Date
CharlesKWON	e368402682	chore: audit cleanup — remove orphan parser + dead TSqlIndex methods Opus 4.7 audit of the codebase surfaced several items that Opus 4.6 sessions left behind. This pass removes what's definitively dead and fixes one trivial defensive bug; the real logic bugs (transaction ordering, missing RunUpdate/RunDelete validation) come in a separate commit. Deletions: - `_FiveSql2/src/TSqlParser_orig.prg` (1173 lines) — superseded by `TSqlParser2.prg` (Pratt). Production never instantiates the old parser; the only callers were the comparison/benchmark test files also being removed. - `_FiveSql2/test/test_parser_cmp.prg` — compared orig vs Pratt AST, useless now that orig is gone. - `_FiveSql2/test/bench_parser.prg` — benched both, same reason. - `_FiveSql2/Makefile` `test_cmp:` and `bench:` targets referenced the removed files. - `TSqlIndex.prg` methods `ApplyScope`, `ClearScope`, `ApplySeek`, `IndexInfo`, `CreateTempIndex`, `DropTempIndex` — each declared in the class header and implemented (~165 lines total) but zero callers anywhere in `_FiveSql2/` or `hbrtl/`. Class declarations removed alongside the bodies. Small fixes: - `TSqlDDL.prg:179-180` stale comment claiming Five doesn't support `@byref` — false since commit `e95afad` (2026-04-13) wired @byref via RefCell. The same method uses @nPos correctly elsewhere. - `hbrt/class.go:tryBinaryOp` defensive nil-check on AsArray(). IsObject() checks the type tag; a corrupted Value with tag=Object but ptr=nil would crash on `.Class`. Correct construction paths never hit this, but the guard is cheap. Compat tests: FiveSql2 43/43, Harbour compat 56/56, Go test ALL PASS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-18 22:46:17 +09:00
Charles KWON OhJun	486e466592	feat: FiveSql2 43/43, @byref, mutable closure, RTL 479, DateTime fix Major changes since last commit: - FiveSql2 SQL:1999 engine (10,458 LOC) — 43/43 ALL PASS - 21 compiler/runtime bugs fixed (short-circuit AND/OR, FOR LOOP, etc.) - @byref pass-by-reference via RefCell pattern - Mutable closure capture (EnsureLocalRef + RefCell sharing) - RTL: 400 → 479 functions (+79: file, string, datetime, hash, UTF-8) - DateTime/Timestamp fully working (hb_DateTime, hb_Hour/Min/Sec, display) - Reserved word guard (39 keywords blocked from function calls) - AEval arg order fix (element before index) - Closure capture redecl fix (unique _cap_ names per block) - Hash/string indexing in ArrayPush/ArrayPop - Harbour compat test suite: 51/51 - 4 docs: Porting Report, Implementation Plan, Optimization Plan, Commercialization Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-11 11:35:37 +09:00

e368402682

chore: audit cleanup — remove orphan parser + dead TSqlIndex methods

Opus 4.7 audit of the codebase surfaced several items that Opus 4.6
sessions left behind. This pass removes what's definitively dead and
fixes one trivial defensive bug; the real logic bugs (transaction
ordering, missing RunUpdate/RunDelete validation) come in a separate
commit.

Deletions:

- `_FiveSql2/src/TSqlParser_orig.prg` (1173 lines) — superseded by
  `TSqlParser2.prg` (Pratt). Production never instantiates the old
  parser; the only callers were the comparison/benchmark test files
  also being removed.
- `_FiveSql2/test/test_parser_cmp.prg` — compared orig vs Pratt AST,
  useless now that orig is gone.
- `_FiveSql2/test/bench_parser.prg` — benched both, same reason.
- `_FiveSql2/Makefile` `test_cmp:` and `bench:` targets referenced
  the removed files.
- `TSqlIndex.prg` methods `ApplyScope`, `ClearScope`, `ApplySeek`,
  `IndexInfo`, `CreateTempIndex`, `DropTempIndex` — each declared in
  the class header and implemented (~165 lines total) but zero
  callers anywhere in `_FiveSql2/` or `hbrtl/`. Class declarations
  removed alongside the bodies.

Small fixes:

- `TSqlDDL.prg:179-180` stale comment claiming Five doesn't support
  `@byref` — false since commit e95afad (2026-04-13) wired @byref
  via RefCell. The same method uses @nPos correctly elsewhere.
- `hbrt/class.go:tryBinaryOp` defensive nil-check on AsArray().
  IsObject() checks the type tag; a corrupted Value with tag=Object
  but ptr=nil would crash on `.Class`. Correct construction paths
  never hit this, but the guard is cheap.

Compat tests: FiveSql2 43/43, Harbour compat 56/56, Go test ALL PASS.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-18 22:46:17 +09:00

Charles KWON OhJun

486e466592

feat: FiveSql2 43/43, @byref, mutable closure, RTL 479, DateTime fix

Major changes since last commit:
- FiveSql2 SQL:1999 engine (10,458 LOC) — 43/43 ALL PASS
- 21 compiler/runtime bugs fixed (short-circuit AND/OR, FOR LOOP, etc.)
- @byref pass-by-reference via RefCell pattern
- Mutable closure capture (EnsureLocalRef + RefCell sharing)
- RTL: 400 → 479 functions (+79: file, string, datetime, hash, UTF-8)
- DateTime/Timestamp fully working (hb_DateTime, hb_Hour/Min/Sec, display)
- Reserved word guard (39 keywords blocked from function calls)
- AEval arg order fix (element before index)
- Closure capture redecl fix (unique _cap_ names per block)
- Hash/string indexing in ArrayPush/ArrayPop
- Harbour compat test suite: 51/51
- 4 docs: Porting Report, Implementation Plan, Optimization Plan, Commercialization

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-04-11 11:35:37 +09:00

2 Commits