CharlesKWON
3a7f1dea72
Three audit findings around polish + a release-readiness commit:
* #UX1 LIST/DISPLAY output: dropped \r\n (unix terminals showed a
stray ^M), moved the newline to AFTER each row (no more leading
blank line), and added the `*` deleted-record marker after the
record number — matches xBase LIST/DISPLAY convention. With
SET DELETED ON the marker is unreachable since the row would
have been skipped at Area.Skip level; with SET DELETED OFF the
user now sees which rows are tombstoned.
* #26 temp aliases: `__copytmp` / `__sorttmp` / `__totaltmp` /
`__jointmp` were process-global string constants. A nested
invocation (e.g., COPY inside a FOR clause whose expression
runs another COPY) collided on the alias and the inner Open
failed with "alias already in use" — surfacing as `.F.` with
no clear cause. Each Open now goes through a new helper
`nextTmpAlias(prefix)` backed by an atomic counter, so every
call gets `__copytmp_1`, `__copytmp_2`, etc. — no collisions.
* #J test coverage gap: the 13 std.ch regression tests were all
sitting in `/tmp` — lost on tmpfs reboot, never in git, never
in CI. Move them into `tests/std_ch/` and add a simple
`run.sh` runner that builds + executes each one in a temp
scratch directory and grep-asserts on FAIL / NOT REJECTED /
expectation-mismatch markers. 13/13 pass against the current
head:
PASS test_pp_stdch PASS test_count
PASS test_sum_avg PASS test_sum_multi
PASS test_copy PASS test_sort
PASS test_list PASS test_total
PASS test_join PASS test_update
PASS test_set_deleted PASS test_unsupported
PASS test_block_comma
test_block_comma in particular guards the gengo SeqExpr fix
from Wave 1 — without it the comma-in-block miscompile would
silently come back.
Gates green:
go test ./... : PASS
FiveSql2 SQL:1999 : 43/43
Harbour compat : 56/56
std.ch suite : 13/13
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
46 lines
1.2 KiB
Plaintext
46 lines
1.2 KiB
Plaintext
/* SUM and AVERAGE via PP rule. */
|
|
|
|
PROCEDURE Main()
|
|
LOCAL aStruct, nSum, nAvg
|
|
|
|
FErase( "people.dbf" )
|
|
aStruct := { { "ID", "N", 4, 0 }, { "AGE", "N", 3, 0 } }
|
|
dbCreate( "people.dbf", aStruct )
|
|
USE people.dbf NEW EXCLUSIVE ALIAS p
|
|
dbAppend() ; FieldPut(1, 1) ; FieldPut(2, 18)
|
|
dbAppend() ; FieldPut(1, 2) ; FieldPut(2, 25)
|
|
dbAppend() ; FieldPut(1, 3) ; FieldPut(2, 30)
|
|
dbAppend() ; FieldPut(1, 4) ; FieldPut(2, 45)
|
|
dbAppend() ; FieldPut(1, 5) ; FieldPut(2, 60)
|
|
dbCommit()
|
|
|
|
/* SUM all ages */
|
|
dbGoTop()
|
|
SUM p->age TO nSum
|
|
? "1. SUM p->age =", nSum, "(expect 178 = 18+25+30+45+60)"
|
|
|
|
/* SUM with FOR */
|
|
dbGoTop()
|
|
SUM p->age TO nSum FOR p->age >= 30
|
|
? "2. SUM p->age FOR age>=30 =", nSum, "(expect 135 = 30+45+60)"
|
|
|
|
/* AVERAGE all ages */
|
|
dbGoTop()
|
|
AVERAGE p->age TO nAvg
|
|
? "3. AVERAGE p->age =", nAvg, "(expect 35.6)"
|
|
|
|
/* AVERAGE with FOR */
|
|
dbGoTop()
|
|
AVERAGE p->age TO nAvg FOR p->age >= 30
|
|
? "4. AVERAGE p->age FOR age>=30 =", nAvg, "(expect 45)"
|
|
|
|
/* AVERAGE with no matching rows */
|
|
dbGoTop()
|
|
AVERAGE p->age TO nAvg FOR p->age > 200
|
|
? "5. AVERAGE p->age FOR age>200 =", nAvg, "(expect 0)"
|
|
|
|
dbCloseArea()
|
|
FErase( "people.dbf" )
|
|
? "DONE"
|
|
RETURN
|