CharlesKWON
3a7f1dea72
Three audit findings around polish + a release-readiness commit:
* #UX1 LIST/DISPLAY output: dropped \r\n (unix terminals showed a
stray ^M), moved the newline to AFTER each row (no more leading
blank line), and added the `*` deleted-record marker after the
record number — matches xBase LIST/DISPLAY convention. With
SET DELETED ON the marker is unreachable since the row would
have been skipped at Area.Skip level; with SET DELETED OFF the
user now sees which rows are tombstoned.
* #26 temp aliases: `__copytmp` / `__sorttmp` / `__totaltmp` /
`__jointmp` were process-global string constants. A nested
invocation (e.g., COPY inside a FOR clause whose expression
runs another COPY) collided on the alias and the inner Open
failed with "alias already in use" — surfacing as `.F.` with
no clear cause. Each Open now goes through a new helper
`nextTmpAlias(prefix)` backed by an atomic counter, so every
call gets `__copytmp_1`, `__copytmp_2`, etc. — no collisions.
* #J test coverage gap: the 13 std.ch regression tests were all
sitting in `/tmp` — lost on tmpfs reboot, never in git, never
in CI. Move them into `tests/std_ch/` and add a simple
`run.sh` runner that builds + executes each one in a temp
scratch directory and grep-asserts on FAIL / NOT REJECTED /
expectation-mismatch markers. 13/13 pass against the current
head:
PASS test_pp_stdch PASS test_count
PASS test_sum_avg PASS test_sum_multi
PASS test_copy PASS test_sort
PASS test_list PASS test_total
PASS test_join PASS test_update
PASS test_set_deleted PASS test_unsupported
PASS test_block_comma
test_block_comma in particular guards the gengo SeqExpr fix
from Wave 1 — without it the comma-in-block miscompile would
silently come back.
Gates green:
go test ./... : PASS
FiveSql2 SQL:1999 : 43/43
Harbour compat : 56/56
std.ch suite : 13/13
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
68 lines
1.7 KiB
Plaintext
68 lines
1.7 KiB
Plaintext
/* UPDATE FROM via PP rule. */
|
|
|
|
PROCEDURE Main()
|
|
LOCAL aStruct
|
|
|
|
FErase( "mas.dbf" )
|
|
FErase( "del.dbf" )
|
|
|
|
/* Master: id, total. Initially totals are zero. */
|
|
aStruct := { ;
|
|
{ "ID", "N", 4, 0 }, ;
|
|
{ "NAME", "C", 8, 0 }, ;
|
|
{ "TOTAL", "N", 8, 2 } }
|
|
dbCreate( "mas.dbf", aStruct )
|
|
USE mas.dbf NEW EXCLUSIVE ALIAS mas
|
|
dbAppend() ; FieldPut(1, 1) ; FieldPut(2, "Alice") ; FieldPut(3, 0)
|
|
dbAppend() ; FieldPut(1, 2) ; FieldPut(2, "Bob") ; FieldPut(3, 0)
|
|
dbAppend() ; FieldPut(1, 3) ; FieldPut(2, "Carol") ; FieldPut(3, 0)
|
|
dbCommit()
|
|
dbCloseArea()
|
|
|
|
/* Delta: same id, amount to apply. Sorted by id. */
|
|
aStruct := { ;
|
|
{ "ID", "N", 4, 0 }, ;
|
|
{ "AMT", "N", 8, 2 } }
|
|
dbCreate( "del.dbf", aStruct )
|
|
USE del.dbf NEW EXCLUSIVE ALIAS del
|
|
dbAppend() ; FieldPut(1, 1) ; FieldPut(2, 100)
|
|
dbAppend() ; FieldPut(1, 2) ; FieldPut(2, 200)
|
|
dbAppend() ; FieldPut(1, 3) ; FieldPut(2, 300)
|
|
dbCommit()
|
|
dbCloseArea()
|
|
|
|
/* Re-open both, sorted on id. */
|
|
USE mas.dbf NEW EXCLUSIVE ALIAS mas
|
|
USE del.dbf NEW EXCLUSIVE ALIAS del
|
|
SELECT mas
|
|
|
|
? "--- before UPDATE FROM ---"
|
|
dbGoTop()
|
|
DO WHILE !Eof()
|
|
? " ", FieldGet(1), AllTrim(FieldGet(2)), FieldGet(3)
|
|
dbSkip()
|
|
ENDDO
|
|
|
|
? ""
|
|
? "--- UPDATE FROM del ON id REPLACE total WITH del->amt ---"
|
|
dbGoTop()
|
|
UPDATE FROM del ON id REPLACE total WITH del->amt
|
|
|
|
? ""
|
|
? "--- after UPDATE FROM ---"
|
|
dbGoTop()
|
|
DO WHILE !Eof()
|
|
? " ", FieldGet(1), AllTrim(FieldGet(2)), FieldGet(3)
|
|
dbSkip()
|
|
ENDDO
|
|
? "(expect: 1 Alice 100, 2 Bob 200, 3 Carol 300)"
|
|
|
|
SELECT del
|
|
dbCloseArea()
|
|
SELECT mas
|
|
dbCloseArea()
|
|
FErase( "mas.dbf" )
|
|
FErase( "del.dbf" )
|
|
? "DONE"
|
|
RETURN
|