The prior loop allocated one small `[]hbrt.Value` per matching row
(for the row body) plus one HbArray header. For a 50k-row full scan
that's 100k allocations of which the small-slice allocs dominated
fragmentation and GC pressure.
SQLite-inspired fix: pre-allocate a single flat []hbrt.Value of
capacity `RecCount * nFields` at scan start and hand each row a
three-index sub-slice (flat[off:end:end]). The capped sub-slice
still forces a reallocation if PRG code later does `AAdd(row, x)`,
so neighbor rows can't get clobbered.
Sizing the initial buffer off RecCount(err-ignored) was the actual
win — the previous naive grow-from-1024 policy caused five mid-scan
reallocations of a ~200 KB buffer, each memcpy'ing everything so far.
One upfront allocation amortizes much better.
Bench (50k rows, ~/tmp ext4, 3 runs steady-state):
Before After Δ
no WHERE 14.6ms 10.6ms −27%
numeric WHERE 11.7ms 10.0ms −15%
string WHERE 10.5ms 11.0ms ~=
raw RDD baseline 6.8ms 7.0ms
Gap to raw RDD: 2.1x → 1.4x on the dominant no-WHERE case. What's
left is pcode WHERE dispatch (ExecPcode frame per row), the Area
interface boundary, and the HbArray header allocation per row —
all structural costs that would need a wider refactor to close.
Validation:
- FiveSql2 43/43
- go test ./hbrtl/... PASS
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
153 lines
4.5 KiB
Go
153 lines
4.5 KiB
Go
// Copyright (c) 2026 Charles KWON OhJun (charleskwonohjun@gmail.com)
|
|
// All rights reserved.
|
|
|
|
// Go-native SQL scan loop for FiveSql2 hot path.
|
|
//
|
|
// Motivation: FiveSql2 is a PRG-based SQL interpreter. For simple
|
|
// "SELECT cols FROM table WHERE cond" queries, the per-row cost is
|
|
// dominated by PRG interpreter overhead (AST tree walk, field name
|
|
// lookup, workarea switching). Moving just the inner scan loop to Go
|
|
// bypasses all that overhead and gets us ~15x speedup for the common
|
|
// case while keeping the rest of FiveSql2 untouched.
|
|
//
|
|
// The SQL engine remains responsible for:
|
|
// - Parsing SQL and building AST
|
|
// - Resolving field names to positions (column binding)
|
|
// - Compiling WHERE expression to pcode (via PcCompile)
|
|
// - GROUP BY, ORDER BY, aggregates (not per-row)
|
|
//
|
|
// This helper only handles the hot loop:
|
|
// - Full table scan (workarea already positioned)
|
|
// - Per-row WHERE evaluation via ExecPcode
|
|
// - Column extraction via cached field positions
|
|
// - Result array construction
|
|
|
|
package hbrtl
|
|
|
|
import (
|
|
"five/hbrdd"
|
|
"five/hbrt"
|
|
)
|
|
|
|
// SqlScan(aFieldPositions, pcWhere) → aRows
|
|
//
|
|
// Scans the current workarea top-to-bottom, evaluates pcWhere per row
|
|
// (nil = no filter), collects selected column values into rows.
|
|
//
|
|
// aFieldPositions: array of 1-based field positions to extract per row.
|
|
// Resolve once before calling (FieldPos cache is O(1)
|
|
// but still has PRG → Go call overhead).
|
|
// pcWhere: pcode function pointer from PcCompile, or NIL.
|
|
//
|
|
// Returns:
|
|
// Array of rows, each row = Array of field values.
|
|
//
|
|
// Notes on CHAR trimming: DBF character fields are space-padded. The
|
|
// caller decides whether to trim (via a SELECT-list AllTrim wrapper).
|
|
// We don't trim here — that's a semantic choice, and callers who need
|
|
// raw bytes shouldn't pay for a strings.TrimSpace().
|
|
func SqlScan(t *hbrt.Thread) {
|
|
t.Frame(2, 0)
|
|
defer t.EndProc()
|
|
|
|
// Parse arguments
|
|
fieldsVal := t.Local(1)
|
|
if !fieldsVal.IsArray() {
|
|
t.PushValue(hbrt.MakeArray(0))
|
|
t.RetValue()
|
|
return
|
|
}
|
|
fieldsArr := fieldsVal.AsArray().Items
|
|
nFields := len(fieldsArr)
|
|
|
|
whereVal := t.Local(2)
|
|
var whereFn *hbrt.PcodeFunc
|
|
if !whereVal.IsNil() {
|
|
if p := whereVal.AsPointer(); p != nil {
|
|
whereFn, _ = p.(*hbrt.PcodeFunc)
|
|
}
|
|
}
|
|
|
|
// Pre-convert field positions to []int (avoid Value->int per row)
|
|
fieldPos := make([]int, nFields)
|
|
for i := 0; i < nFields; i++ {
|
|
fieldPos[i] = int(fieldsArr[i].AsNumInt())
|
|
if fieldPos[i] < 1 {
|
|
fieldPos[i] = 1
|
|
}
|
|
}
|
|
|
|
wam, ok := t.WA.(*hbrdd.WorkAreaManager)
|
|
if !ok {
|
|
t.PushValue(hbrt.MakeArray(0))
|
|
t.RetValue()
|
|
return
|
|
}
|
|
area := wam.Current()
|
|
if area == nil {
|
|
t.PushValue(hbrt.MakeArray(0))
|
|
t.RetValue()
|
|
return
|
|
}
|
|
|
|
// SQLite-inspired: instead of one slice allocation per row, maintain
|
|
// a single flat backing buffer and hand each row a sub-slice into it.
|
|
// This halves allocations (row header + backing → just row header)
|
|
// and keeps row data contiguous in memory for better cache locality.
|
|
//
|
|
// Safety: we cap each sub-slice to exactly nFields via the 3-index
|
|
// slice form (flat[off:end:end]). Any later `append` on an individual
|
|
// row will then trigger a reallocation of that row's backing, so we
|
|
// don't clobber neighboring rows if PRG code mutates via AAdd.
|
|
// Size the initial backing based on the workarea's record count —
|
|
// even if WHERE filters most rows out, over-allocating beats five
|
|
// regrowths of a 200 KB buffer mid-scan.
|
|
estRows := 1024
|
|
if rc, err := area.RecCount(); err == nil && rc > 0 {
|
|
estRows = int(rc)
|
|
if estRows > 1 << 20 {
|
|
estRows = 1 << 20
|
|
}
|
|
}
|
|
rows := make([]hbrt.Value, 0, estRows)
|
|
flat := make([]hbrt.Value, 0, estRows*nFields)
|
|
|
|
// Scan
|
|
area.GoTop()
|
|
for !area.EOF() {
|
|
// WHERE evaluation (if any)
|
|
keep := true
|
|
if whereFn != nil {
|
|
hbrt.ExecPcode(t, whereFn, nil)
|
|
keep = t.GetRetValue().AsBool()
|
|
}
|
|
|
|
if keep {
|
|
// Reserve nFields slots in flat, growing if needed.
|
|
off := len(flat)
|
|
end := off + nFields
|
|
if end > cap(flat) {
|
|
// Grow flat. Go's append growth policy handles this;
|
|
// we re-reserve space so the sub-slice math still holds.
|
|
flat = append(flat, make([]hbrt.Value, nFields)...)
|
|
} else {
|
|
flat = flat[:end]
|
|
}
|
|
row := flat[off:end:end]
|
|
|
|
// Collect column values directly into the backing buffer.
|
|
for i := 0; i < nFields; i++ {
|
|
// GetValue is 0-based
|
|
v, _ := area.GetValue(fieldPos[i] - 1)
|
|
row[i] = v
|
|
}
|
|
rows = append(rows, hbrt.MakeArrayFrom(row))
|
|
}
|
|
|
|
area.Skip(1)
|
|
}
|
|
|
|
t.PushValue(hbrt.MakeArrayFrom(rows))
|
|
t.RetValue()
|
|
}
|