Files
five/hbrdd/dbf/locks_posix.go
CharlesKWON cde86730b8 fix(compiler,hbrt,hbrdd,cli): pre-1.0 audit — 13 critical fixes
Senior-engineer / QA audit landed 13 silent-miscompile and data-
integrity fixes spanning the whole compiler+runtime+storage stack.
Each fix is paired with either an integration test in the suite or
a focused regression check; all 6 release gates stay green:
go test ./..., FiveSql2 43/43, Harbour compat 56/56, std.ch 17/17,
FRB 7/7, examples 65/71.

Compiler
--------

* genpc IF/ELSEIF jumpEnd2 patching (compiler/genpc/genpc.go).
  Per-ELSEIF branch terminators were stashed into `_ = jumpEnd2`
  and never patched — the relative offset stayed 0 and the runtime
  walked the next ELSEIF's PcOpJumpFalse opcode as if it were
  jump-offset data. Bytecode-level corruption in pcode mode. Now
  collected into a slice and patched at end-of-IF. Verified via
  Grade(95..50) cases 11a-e added to tests/frb/test_frb_pcode_sweep.

* countLocalsInStmts / scanBodyLocals missing bodies
  (compiler/gengo/gen_util.go, compiler/gengo/gengo.go). Frame-size
  counter skipped WATCH/TIMEOUT/PARALLEL FOR bodies, so a LOCAL
  declared inside one of those constructs got a slot index past
  the runtime's allocated count — silent NIL reads or out-of-range
  stomps.

* emitMethodDeclStandalone nested LOCAL (compiler/gengo/gen_class.go).
  Same bug class but on the *method* side. Pre-fix repro:

      METHOD Stomp(n) CLASS T
         LOCAL a := 1, b := 2
         IF n > 0
            LOCAL c := 30, d := 40, e := 50, f := 60
            Inner( n )
            IF c != 30 .OR. d != 40 .OR. e != 50 .OR. f != 60 ...

  printed `c, d, e, f = 5, NIL, NIL, NIL` because Inner's frame
  collided with Stomp's underallocated slot range. Now counts
  body-nested LOCALs into the frame and pre-allocates indices via
  scanBodyLocals.

* genpc unsupported-AST diagnostic surface (compiler/genpc/genpc.go,
  hbrt/pcode.go, cmd/five/main.go, hbrtl/frb.go). The `default`
  cases in emitStmt / emitExpr silently emitted PushNil / no-op
  for nodes the pcode generator doesn't implement (ClassDecl,
  MethodDecl, xBase commands, concurrency primitives, …). Added
  `PcodeModule.Warnings []string` populated by noteUnsupported,
  surfaced on stderr from the build pipeline. Users now see
  "pcode: AST node not supported in --pcode/FRB-pcode mode: stmt
  *ast.GoBlockStmt" instead of getting a silently broken module.

Runtime
-------

* class.go Send/tryBinaryOp t.self defer-restore (hbrt/class.go).
  Restoration was a plain `t.self = oldSelf` after `fn(t)`. Any
  panic in the method body skipped the line, so the next BEGIN
  SEQUENCE / RECOVER handler ran with the THROWING object's Self
  — `::field` resolved against the wrong receiver. Wrapped both
  restore sites in `defer func() { t.self = oldSelf }()`.
  Verified: pre-fix RECOVER saw "THROWER", post-fix "OUTER".

* hbfunc.go HB_FUNC parameter Frame() (hbrt/hbfunc.go). The
  RegisterDynamicFunc wrapper called `fn(ctx)` without ever
  calling Frame, so `ctx.ParC(1)` / `ctx.Local(n)` read through
  `t.curFrame.localBase + n - 1` against the *caller's* frame.
  Every #pragma BEGINDUMP HB_FUNC taking parameters silently
  returned "" / 0 / "" for them — masked by ParNIDef-style
  defaults. Wrapper now does `t.Frame(t.pendingParams, 0); defer
  t.EndProc()` before dispatch.

* pcode codeblock closure capture (hbrt/pcinterp.go, hbrt/pcode.go,
  hbrt/thread.go, compiler/genpc/genpc.go). PcOpPushBlock recorded
  `nDetached` but never copied enclosing locals; free vars in the
  block body fell through to memvar lookup → NIL. Wired full
  capture pipeline:
  - New opcodes PcOpPushDetached (0x59) / PcOpPopDetached (0x5A).
  - PushBlock now reads per-slot source-local indices and
    snapshots into bb.Detached at construction time.
  - New detachedMap in genpc auto-promotes any free var that
    resolves to an enclosing-frame local into a capture slot.
  - emitAssignAsExpr leaves the assigned value on the eval stack
    so SeqExpr items like `{|v| acc += v, acc }` work.
  - Thread tracks curBlock with paired Set/restore in the block's
    Fn wrapper for nested-block evaluation.
  Mutating capture (acc += v across successive Evals) now works.

* vm.NewThread statics + waFactory propagation (hbrt/vm.go).
  GoLaunch / GoLaunchBlock call NewThread directly. Previously
  the statics map and WA factory were applied only in Run(), so
  goroutine-spawned PRG code panicked on STATIC access ("static
  index out of range") and crashed dereferencing nil WA on any
  DB call. Both now happen inside NewThread under the same lock
  as TID assignment.

Data layer
----------

* dbf concurrent Append lock (hbrdd/dbf/dbf.go,
  hbrdd/dbf/locks_posix.go, hbrdd/dbf/locks_windows.go). Append
  bumped a local recCount with no file-system serialization. Two
  shared-mode processes both wrote at the same RecordOffset; one
  record silently overwrote the other. Added an append-intent
  byte-range lock at offset 0x7FFFFFFE + bounded retry, on-disk
  header refresh inside the locked region, and immediate header
  write so peers refresh past our slot.

* indexer negative numeric key encoding (hbrdd/dbf/indexer.go +
  new hbrdd/dbf/encode_numeric_test.go). `%20.10f` formats `-100`
  as `"     -100.0000000000"` and `99` as `"        99.0000000000"`.
  ASCII ' ' (0x20) < '-' (0x2D), so `99` lex-compared LESS than
  `-100` — every NTX/CDX index over a column that ever held a
  negative number returned wrong rows for SEEK / range scans.
  Replaced with a 1-byte sign prefix + 21-byte zero-padded
  magnitude (negatives use digit-complement) so byte order
  matches numeric order across signs and magnitudes. Format
  change: existing indexes built with the old encoding must be
  REINDEXed. Three unit tests pin the order.

* dbf Append index maintenance hooks (hbrdd/dbf/dbf.go,
  hbrdd/dbf/indexer.go). Append never inserted into open NTX/CDX
  indexes — the audit's canonical scenario `SET INDEX TO …;
  APPEND BLANK; REPLACE …; dbSeek …` silently missed the new
  record. Added optional IndexWriter interface, queue the new
  recNo in pendingIdxInserts, drain after flushRecord by calling
  InsertKey on every open writer-supporting engine. NTX
  participates (its existing rebuild-on-insert is correct);
  CDX online maintenance is deferred to a follow-up — those
  indexes still need REINDEX. Verified: post-fix SEEK("Charlie")
  after APPEND BLANK + REPLACE finds the new record.

* dbf PACK crash-safety (hbrdd/dbf/dbf.go). The old in-place
  rewrite read record N, overwrote slot M<N, then truncated.
  Power loss after partial loop left a file with overwritten
  prefix and no original copies of the records already advanced
  past — silent data loss. Rewrote to:
    1) drop mmap, build `<file>.pack.tmp` with all surviving
       records,
    2) Sync(),
    3) close original handle + os.Rename(tmp, orig) (atomic on
       same FS),
    4) reopen + re-mmap.
  TestComp_Pack passes; readers always see either the pre-PACK
  or post-PACK contents, never a half-state.

* mem RDD torn reads (hbrdd/mem/memrdd.go). The comment claimed
  in-place PutValue was safe because hbrt.Value "fits in a
  single machine word + pointer". hbrt.Value is 24 bytes (3
  words) — a concurrent reader could observe new type tag with
  stale scalar/ptr and type-confuse on the next AsXxx() call.
  Switched mu to sync.RWMutex; GetValue takes RLock,
  Append/PutValue/Delete/Recall take Lock. `go test -race
  ./hbrdd/mem/` clean.

Files touched
-------------

  compiler/gengo/gen_class.go, gen_util.go, gengo.go
  compiler/genpc/genpc.go
  hbrt/class.go, hbfunc.go, pcinterp.go, pcode.go, thread.go, vm.go
  hbrdd/dbf/dbf.go, indexer.go, locks_posix.go, locks_windows.go
  hbrdd/dbf/encode_numeric_test.go  (new)
  hbrdd/mem/memrdd.go
  cmd/five/main.go
  hbrtl/frb.go
  tests/frb/test_frb_pcode_sweep.prg

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 05:29:56 +09:00

214 lines
6.2 KiB
Go
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
// Copyright (c) 2026 Charles KWON OhJun (charleskwonohjun@gmail.com)
// All rights reserved.
//go:build !windows
// POSIX file locking (fcntl byte-range locks) for DBF shared mode.
// Equivalent to Harbour's hb_fsLockLarge / F_SETLK implementation.
//
// We use POSIX advisory byte-range locks (F_SETLK / F_SETLKW) rather than
// flock(2) because:
// 1. Byte-range granularity is required for record-level DBRLOCK semantics
// 2. POSIX fcntl locks work across NFS (flock does not)
// 3. Harbour and Clipper both use this exact mechanism on *nix
//
// Lock regions (compatible with Harbour's NETIO layout):
// - FLOCK (whole-file exclusive): high byte in 32-bit range, len = large
// - DBRLOCK (single record): at RecordOffset(n), len = RecordLen
//
// The high-offset file lock avoids overlapping with record locks so that
// both can coexist on the same file descriptor.
package dbf
import (
"fmt"
"syscall"
"time"
)
// flockAll acquires/releases an exclusive lock on the DBF header area.
// We use offset 0, length = HeaderLen + 1 so that:
// - FLOCK blocks all writers that would touch the header
// - Record locks (at RecordOffset(n), past the header) don't conflict
const flockOffset = int64(0)
// appendLockOffset is the byte range used to serialize concurrent
// APPEND across processes. We park it well above any realistic 32-bit
// DBF record offset so it doesn't collide with FLOCK (header) or
// record locks. POSIX fcntl allows locking byte ranges past EOF.
// Harbour's protocol uses an equivalent special offset for append.
const appendLockOffset = int64(0x7FFFFFFE)
const appendLockLen = int64(1)
func flockLen(a *DBFArea) int64 {
return int64(a.header.HeaderLen) + 1
}
// lockAppendIntent acquires the append-intent lock with bounded
// retries. Without serialization, two processes simultaneously
// running APPEND would both read the same `recCount` from the
// header, write at the same RecordOffset, and one record would
// silently overwrite the other.
//
// The retry budget is intentionally short — append contention is
// usually a few hundred microseconds, so a long block here is the
// signal of a misbehaving peer rather than legitimate competition.
func (a *DBFArea) lockAppendIntent() error {
if a.dataFile == nil {
return fmt.Errorf("file not open")
}
fd := int(a.dataFile.Fd())
deadline := 100 // ~100 ms total (1 ms × 100); cheap bound vs blocking F_SETLKW
for i := 0; i < deadline; i++ {
ok, err := tryLock(fd, appendLockOffset, appendLockLen)
if err != nil {
return err
}
if ok {
return nil
}
time.Sleep(time.Millisecond)
}
return fmt.Errorf("APPEND: could not acquire append-intent lock (peer holding too long)")
}
func (a *DBFArea) unlockAppendIntent() error {
if a.dataFile == nil {
return nil
}
return unlockRange(int(a.dataFile.Fd()), appendLockOffset, appendLockLen)
}
// tryLock acquires an exclusive byte-range lock. Non-blocking: returns
// (false, nil) if another process already holds a conflicting lock,
// (false, err) on system error, (true, nil) on success.
func tryLock(fd int, start, length int64) (bool, error) {
flk := &syscall.Flock_t{
Type: syscall.F_WRLCK,
Whence: int16(0), // SEEK_SET
Start: start,
Len: length,
}
err := syscall.FcntlFlock(uintptr(fd), syscall.F_SETLK, flk)
if err == nil {
return true, nil
}
if err == syscall.EAGAIN || err == syscall.EACCES {
// Another process holds a conflicting lock.
return false, nil
}
return false, err
}
// unlockRange releases a byte-range lock previously acquired with tryLock.
func unlockRange(fd int, start, length int64) error {
flk := &syscall.Flock_t{
Type: syscall.F_UNLCK,
Whence: int16(0),
Start: start,
Len: length,
}
return syscall.FcntlFlock(uintptr(fd), syscall.F_SETLK, flk)
}
// LockFile tries to acquire an exclusive FLOCK on the DBF file.
// Non-blocking. Returns false if another process already holds any lock
// on the header region. Harbour: hb_dbfLock(a, DBOI_LOCKMODE_FILE).
func (a *DBFArea) LockFile() (bool, error) {
if a.dataFile == nil {
return false, fmt.Errorf("file not open")
}
if a.fileLocked {
return true, nil // already held
}
ok, err := tryLock(int(a.dataFile.Fd()), flockOffset, flockLen(a))
if err != nil {
return false, err
}
if ok {
a.fileLocked = true
}
return ok, nil
}
// UnlockFile releases the FLOCK held by this workarea.
func (a *DBFArea) UnlockFile() error {
if a.dataFile == nil || !a.fileLocked {
return nil
}
if err := unlockRange(int(a.dataFile.Fd()), flockOffset, flockLen(a)); err != nil {
return err
}
a.fileLocked = false
return nil
}
// LockRecord tries to acquire an exclusive lock on a single record.
// recNo == 0 means "current record". Non-blocking.
// Harbour: hb_dbfLock(a, DBOI_LOCKMODE_RECORD).
func (a *DBFArea) LockRecord(recNo uint32) (bool, error) {
if a.dataFile == nil {
return false, fmt.Errorf("file not open")
}
if recNo == 0 {
recNo = a.recNo
}
if recNo == 0 {
return false, nil
}
if a.lockedRecs != nil && a.lockedRecs[recNo] {
return true, nil // already held
}
start := a.header.RecordOffset(recNo)
length := int64(a.header.RecordLen)
ok, err := tryLock(int(a.dataFile.Fd()), start, length)
if err != nil {
return false, err
}
if ok {
if a.lockedRecs == nil {
a.lockedRecs = make(map[uint32]bool, 16)
}
a.lockedRecs[recNo] = true
}
return ok, nil
}
// UnlockRecord releases a single record lock. recNo == 0 unlocks ALL held
// record locks (Harbour behavior for DBRUNLOCK() with no args).
func (a *DBFArea) UnlockRecord(recNo uint32) error {
if a.dataFile == nil {
return nil
}
if recNo == 0 {
// Release all record locks
if a.lockedRecs == nil {
return nil
}
length := int64(a.header.RecordLen)
for r := range a.lockedRecs {
start := a.header.RecordOffset(r)
_ = unlockRange(int(a.dataFile.Fd()), start, length)
}
a.lockedRecs = nil
return nil
}
if a.lockedRecs == nil || !a.lockedRecs[recNo] {
return nil // not held
}
start := a.header.RecordOffset(recNo)
length := int64(a.header.RecordLen)
if err := unlockRange(int(a.dataFile.Fd()), start, length); err != nil {
return err
}
delete(a.lockedRecs, recNo)
return nil
}
// releaseAllLocks is called on Close to release any held locks.
func (a *DBFArea) releaseAllLocks() {
_ = a.UnlockFile()
_ = a.UnlockRecord(0)
}