Charles KWON OhJun d7513eeb24 fix: Code review round 2 — race conditions, dead code, hardcoded paths ...

CRITICAL fixes:
- #1 vm.go: Mutex on libModules/dynamicFuncs global slices
  RegisterLibModule/RegisterDynamicFunc now thread-safe
  RegisterLibModules copies under lock, clears, releases
- #4 shutdown.go: Signal handler goroutine leak fixed
  Uses done channel + select for clean exit on normal shutdown

HIGH fixes:
- #7-8 gobridge.go: Remove dead if/else branches (both identical)
- #13-14 main.go: Remove hardcoded /mnt/d/harbour-core paths
  Use HB_INC env var + standard /usr/local/include/harbour only
- #15 main.go: Remove unused frbModSeq variable

MEDIUM fixes:
- #22 expr.go: Remove unused parts variable in parseInterpolatedString
- #51 macro.go: Remove var _ = fmt.Sprintf import guard
- macroeval.go: Remove unused lexer import and guard

Total fixed this session: 12/53 issues resolved
Remaining: 41 (CRITICAL: 1, HIGH: 9, MEDIUM: 16, LOW: 16)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-04-01 10:32:09 +09:00

..

.pdca-snapshots

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

.bkit-memory.json

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

.pdca-status.json

fix: Code review round 2 — race conditions, dead code, hardcoded paths

2026-04-01 10:32:09 +09:00

dbf-engine-spec.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

five-development-plan.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

five-intro-en.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

five-intro-ko.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

five-philosophy-en.md

docs: Strengthen Five Philosophy — full manifesto with real-world stories

2026-03-31 12:13:21 +09:00

five-philosophy-ko.md

docs: Strengthen Five Philosophy — full manifesto with real-world stories

2026-03-31 12:13:21 +09:00

five-readability-en.md

fix: Critical code review fixes — race conditions, panic recovery, LTRIM/RTRIM

2026-04-01 10:17:30 +09:00

five-readability-ko.md

docs: Fix readability docs — Five supports DEFER too

2026-03-31 09:57:47 +09:00

five-syntax-en.md

docs: Add math section to syntax reference + improve example comments

2026-03-31 11:31:44 +09:00

five-syntax-ko.md

docs: Add math section to syntax reference + improve example comments

2026-03-31 11:31:44 +09:00

frb.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

go-interop-en.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

go-interop-ko.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

go-performance-en.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

go-performance-ko.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

harbour-go-compiler-design-review.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

harbour-go-evolution-strategy.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

harbour-prg-to-go-transpiler.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

harbour-type-system-analysis.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

json.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

learning.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

rdd-architecture-spec.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

rushmore.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

todo.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00

tsgo-reference-analysis.md

Five v0.9 — Harbour + Go fusion language

2026-03-31 09:41:50 +09:00