From 79ffe0313895e3ae21f28fbbea37e16d7266bf0b Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Fri, 8 Feb 2013 11:00:22 +0000 Subject: [PATCH] 2013-02-08 11:58 UTC+0100 Viktor Szakats (harbour syenar.net) * utils/hbmk2/hbmk2.prg + show warning and offer best practice when non-portable ".exe" extension is used in -o option + show warning and offer best practice when non-portable "*.lib" library name is passed directly to hbmk2 --- harbour/ChangeLog.txt | 7 +++++++ harbour/utils/hbmk2/hbmk2.prg | 4 ++++ 2 files changed, 11 insertions(+) diff --git a/harbour/ChangeLog.txt b/harbour/ChangeLog.txt index 5edc7721ff..3645bd4f7b 100644 --- a/harbour/ChangeLog.txt +++ b/harbour/ChangeLog.txt @@ -10,6 +10,13 @@ * Change, ! Fix, % Optimization, + Addition, - Removal, ; Comment */ +2013-02-08 11:58 UTC+0100 Viktor Szakats (harbour syenar.net) + * utils/hbmk2/hbmk2.prg + + show warning and offer best practice when non-portable + ".exe" extension is used in -o option + + show warning and offer best practice when non-portable + "*.lib" library name is passed directly to hbmk2 + 2013-02-07 22:53 UTC+0100 Viktor Szakats (harbour syenar.net) * ChangeLog.txt * missed to tag prev entry as needed diff --git a/harbour/utils/hbmk2/hbmk2.prg b/harbour/utils/hbmk2/hbmk2.prg index 8c0cdace97..41979de91c 100644 --- a/harbour/utils/hbmk2/hbmk2.prg +++ b/harbour/utils/hbmk2/hbmk2.prg @@ -2780,6 +2780,9 @@ FUNCTION hbmk( aArgs, nArgTarget, /* @ */ lPause, nLevel ) IF ! Empty( tmp ) tmp := PathSepToSelf( tmp ) hb_FNameSplit( tmp, @cDir, @cName, @cExt ) + IF Lower( cExt ) == ".exe" .AND. hbmk_TARGETTYPE( hbmk ) == "hbexe" + _hbmk_OutErr( hbmk, hb_StrFormat( I_( "Warning: Non-portable option: %1$s. Delete '.exe' extension." ), ParamToString( aParam ) ) ) + ENDIF DO CASE CASE Empty( cDir ) tmp := hb_PathNormalize( PathMakeAbsolute( tmp, aParam[ _PAR_cFileName ] ) ) @@ -3312,6 +3315,7 @@ FUNCTION hbmk( aArgs, nArgTarget, /* @ */ lPause, nLevel ) cParam := PathSepToSelf( cParam ) IF hb_FNameExt( cParamL ) == ".lib" cParam := FNameDirName( cParam ) + _hbmk_OutErr( hbmk, hb_StrFormat( I_( "Warning: Non-portable option: %1$s. Use '-l%2$s' instead." ), ParamToString( aParam ), cParam ) ) ENDIF IF CheckLibParam( hbmk, cParam ) IF _IS_AUTOLIBSYSPRE( cParam )