From 9b271f6e19b56c4173cb0c9611a7e78e4ee79ed5 Mon Sep 17 00:00:00 2001 From: Tamas Tevesz Date: Mon, 8 Aug 2011 13:59:28 +0000 Subject: [PATCH] 2011-08-08 15:55 UTC+0200 Tamas TEVESZ (ice extreme.hu) * contrib/hbct/ctwin.c ! use correct format string for int * contrib/hbexpat/internal.c ! fix comparison of integers of different signs * contrib/hbnf/fttext.c ! remove extraneous parentheses ; issues found by Clang --- harbour/ChangeLog | 12 ++++++++++++ harbour/contrib/hbct/ctwin.c | 2 +- harbour/contrib/hbexpat/internal.c | 2 +- harbour/contrib/hbnf/fttext.c | 4 ++-- 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/harbour/ChangeLog b/harbour/ChangeLog index 83b87e4b1c..3ff59c2f80 100644 --- a/harbour/ChangeLog +++ b/harbour/ChangeLog @@ -16,6 +16,18 @@ The license applies to all entries newer than 2009-04-28. */ +2011-08-08 15:55 UTC+0200 Tamas TEVESZ (ice extreme.hu) + * contrib/hbct/ctwin.c + ! use correct format string for int + + * contrib/hbexpat/internal.c + ! fix comparison of integers of different signs + + * contrib/hbnf/fttext.c + ! remove extraneous parentheses + + ; issues found by Clang + 2011-08-08 12:25 UTC+0200 Przemyslaw Czerpak (druzus/at/priv.onet.pl) * harbour/contrib/hbwin/olecore.c ! typo in previous commit diff --git a/harbour/contrib/hbct/ctwin.c b/harbour/contrib/hbct/ctwin.c index ca5da1e305..4c5fda012e 100644 --- a/harbour/contrib/hbct/ctwin.c +++ b/harbour/contrib/hbct/ctwin.c @@ -1711,7 +1711,7 @@ static HB_BOOL hb_ctw_gt_PutChar( PHB_GT pGT, int iRow, int iCol, PHB_GTCTW pCTW; int iWindow, iCurrWindow; - HB_TRACE(HB_TR_DEBUG, ("hb_ctw_gt_PutChar(%p,%d,%d,%d,%d,%hu)", pGT, iRow, iCol, iColor, (int)bAttr, (int)usChar)); + HB_TRACE(HB_TR_DEBUG, ("hb_ctw_gt_PutChar(%p,%d,%d,%d,%d,%d)", pGT, iRow, iCol, iColor, (int)bAttr, (int)usChar)); pCTW = HB_GTCTW_GET( pGT ); iWindow = iCurrWindow = HB_CTW_GETCURRENT( pCTW ); diff --git a/harbour/contrib/hbexpat/internal.c b/harbour/contrib/hbexpat/internal.c index fefc30a6a5..cde1f3dc2e 100644 --- a/harbour/contrib/hbexpat/internal.c +++ b/harbour/contrib/hbexpat/internal.c @@ -60,7 +60,7 @@ HB_FUNC( __HB_XML_CDPU16MAP ) if( cdp ) { PHB_ITEM pMap = hb_itemArrayNew( UCHAR_MAX + 1 ); - int tmp; + unsigned int tmp; for( tmp = 0; tmp <= UCHAR_MAX; ++tmp ) hb_arraySetNI( pMap, tmp + 1, hb_cdpGetU16( cdp, ( HB_UCHAR ) tmp ) ); diff --git a/harbour/contrib/hbnf/fttext.c b/harbour/contrib/hbnf/fttext.c index 3e424ec303..edb06b2199 100644 --- a/harbour/contrib/hbnf/fttext.c +++ b/harbour/contrib/hbnf/fttext.c @@ -431,8 +431,8 @@ static long _ft_skip( long iRecs ) iBytesRemaining = 0; } } - } while ( ( iBytesRemaining > 0 ) ); - } while( ( iBytesRead == BUFFSIZE ) ); + } while( iBytesRemaining > 0 ); + } while( iBytesRead == BUFFSIZE ); } else {