2010-02-08 22:49 UTC+0100 Viktor Szakats (harbour.01 syenar.hu)
* src/pp/ppcore.c
* src/pp/hbpp.c
* src/vm/macro.c
* src/vm/runner.c
* src/vm/estack.c
* src/vm/itemapi.c
* src/vm/hvm.c
* src/vm/cmdarg.c
* src/vm/maindllp.c
* src/vm/fm.c
* src/vm/thread.c
* src/vm/memvars.c
* src/vm/eval.c
* src/vm/extend.c
* src/vm/classes.c
* src/debug/dbgentry.c
* src/common/expropt1.c
* src/common/expropt2.c
* src/common/hbhash.c
* src/nortl/nortl.c
* src/macro/macrolex.c
* src/rtl/gtxwc/gtxwc.c
* src/rtl/gtstd/gtstd.c
* src/rtl/gtcgi/gtcgi.c
* src/rtl/errapi.c
* src/rtl/hbprocfn.c
* src/rtl/hbsocket.c
* src/rtl/gtpca/gtpca.c
* src/rtl/filebuf.c
* src/rtl/hbproces.c
* src/rdd/dbfntx/dbfntx1.c
* src/rdd/dbsql.c
* src/rdd/hbdbsort.c
* src/rdd/workarea.c
* src/rdd/wacore.c
* src/rdd/sdf1.c
* src/rdd/dbcmdx.c
* src/rdd/dbfnsx/dbfnsx1.c
* src/rdd/dbcmd.c
* src/rdd/dbfcdx/dbfcdx1.c
* src/rdd/delim1.c
* src/rdd/dbf1.c
* src/rdd/hsx/hsx.c
* src/rdd/usrrdd/usrrdd.c
* src/rdd/wafunc.c
* src/rdd/dbffpt/dbffpt1.c
* src/rdd/hbsix/sxord.c
* src/rdd/hbsix/sxfname.c
* src/rdd/hbsix/sxtable.c
* src/rdd/hbsix/sxutil.c
* src/rdd/hbsix/sxcrypt.c
* src/compiler/ppcomp.c
* src/compiler/hbmain.c
* src/compiler/compi18n.c
* src/compiler/cmdcheck.c
* src/compiler/hbdbginf.c
* src/compiler/hbpcode.c
* src/compiler/genhrb.c
* src/compiler/hbdead.c
* src/compiler/complex.c
* src/compiler/genobj32.c
* src/compiler/genc.c
* src/compiler/hbopt.c
* src/compiler/hbident.c
* src/compiler/gencc.c
* src/compiler/hbcmplib.c
* src/compiler/hblbl.c
* src/compiler/harbour.yyc
* src/compiler/harbour.y
* include/hbpp.h
* include/hbrdddbf.h
* include/hbvmpub.h
* include/hbrddnsx.h
* include/hbstack.h
* include/hbgtcore.h
* include/hbapifs.h
* include/hbthread.h
* include/hbdefs.h
* include/hbmacro.h
* include/hbinit.h
* include/hbtypes.h
* include/hbrddsdf.h
* include/hbapi.h
* include/hbapiitm.h
* include/hbrddntx.h
* include/hbvm.h
* include/hbapidbg.h
* include/hbcomp.h
* include/hbapirdd.h
* include/hbcompdf.h
* include/hbrdddel.h
* include/hbexpra.c
* include/hbexprop.h
* include/hbrddcdx.h
* include/hbapicls.h
* include/hbapierr.h
* include/hbrddfpt.h
* include/hbhash.h
* include/hbregex.h
* include/hbexprb.c
* contrib/hbct/screen2.c
* contrib/hbct/token2.c
* contrib/hbct/dbftools.c
* contrib/hbct/atadjust.c
* contrib/hbct/ctwin.c
* contrib/hbct/files.c
* contrib/hbct/dattime3.c
* contrib/hbct/ctstr.c
* contrib/hbct/screen1.c
* contrib/hbct/token1.c
* contrib/hbct/ctc.c
* contrib/hbct/ct.h
* contrib/hbct/atnum.c
* contrib/hbct/asciisum.c
* contrib/hbct/numat.c
* contrib/hbct/atrepl.c
* contrib/xhb/bkgtsks.c
* contrib/xhb/hbcrypt.c
* contrib/xhb/fparse.c
* contrib/xhb/datesxhb.c
* contrib/xhb/hbnxs.h
* contrib/hbqt/gtqtc/gtqtc.cpp
* contrib/xpp/dbcmdx.c
* contrib/hbnf/dispc.c
* contrib/hbnf/ftattr.c
* contrib/hbmemio/memio.c
* contrib/hbnetio/netiocli.c
* contrib/rddsql/sddmy/mysqldd.c
* contrib/rddsql/sddpg/pgsqldd.c
* contrib/rddsql/sddfb/fbirddd.c
* contrib/rddsql/sddodbc/odbcdd.c
* contrib/rddsql/hbrddsql.h
* contrib/rddsql/sqlbase.c
* contrib/rddsql/sqlmix.c
* contrib/rddads/adsx.c
* contrib/rddads/adsfunc.c
* contrib/rddads/rddads.h
* contrib/rddads/ads1.c
* contrib/rddads/adsmgmnt.c
* contrib/hbmisc/spd.c
* contrib/hbtip/utils.c
* contrib/hbtip/encmthd.c
* contrib/hbbmcdx/bmdbfcdx.c
* contrib/hbbmcdx/hbbmcdx.h
* contrib/hbbtree/hb_btree.h
* contrib/hbbtree/hb_btree.c
* ULONG -> HB_ULONG, HB_SIZE
(except for external (OS) API specific usage)
* Formatting.
; NOTE: I converted ULONG to HB_SIZE where I felt it appropriate,
but didn't touch compiler, codeblock handling, low-level
RDD (Set/GetVarLen method) and high-level contrib RDDs, so
this needs to be cleaned.
Also there may be cases where I didn't change the whole
call chain to HB_SIZE.
; NOTE: It would be probably worthy to add new types for these purposes:
- line number (HB_USHORT)
- record number (HB_ULONG)
- RDD connection (HB_ULONG)
- parameter count / stack position / class member positions / etc (HB_USHORT, sometimes HB_ULONG)
- pcode (HB_BYTE and char)
- flags / modes (HB_USHORT / HB_ULONG)
- timers (HB_ULONG, HB_MAXINT)
- GT API character (HB_USHORT)
; REQUESTS:
- Pls don't over-align variable declarations. It makes
modification much much slower. Sometimes declarations are
aligned even if there was only one or two of them in a block.
- Pls always add variable names in declarations, otherwise the purpose
of the function is very slow to decipher when looking at it.
- Keep up the nice formatting according to Harbour standards,
it makes modifications much much easier.
; TODO:
- Verify with grep script
- Verify with HB_USER_CFLAGS=-DHB_LEGACY_TYPES_OFF
- Make HB_LEGACY_TYPES_OFF default for Harbour builds.
- Tie HB_LEGACY_TYPES_OFF to HB_LEGACY_LEVEL3
- Replace current windows.h inclusion hack with regular method
- Delete hacks dealing with former type chaos:
HB_CLIPPER_INT_ITEMS, HB_DONT_DEFINE_BASIC_TYPES, HB_DONT_DEFINE_BOOL, HB_DONT_DEFINE_BYTE, HB_DONT_DEFINE_LONG
- Retest hbfimage on *nix, delete hacks
- Normalize HB_BYTE vs. HB_UCHAR usage
- Type cleanups, f.e. HB_SIZE vs. HB_ULONG
- Add new special types (see above)
- Switch HB_SIZE to signed (big project), and delete HB_ISIZ afterwards.
This commit is contained in:
@@ -64,8 +64,8 @@
|
||||
|
||||
static HB_USHORT s_rddidSQLBASE = 0;
|
||||
static SQLDDCONNECTION * s_pConnection = NULL;
|
||||
static ULONG s_ulConnectionCount = 0;
|
||||
static ULONG s_ulConnectionCurrent = 0;
|
||||
static HB_ULONG s_ulConnectionCount = 0;
|
||||
static HB_ULONG s_ulConnectionCurrent = 0;
|
||||
static char * s_szError = NULL;
|
||||
static HB_ERRCODE s_errCode = 0;
|
||||
static char * s_szQuery = NULL;
|
||||
@@ -126,9 +126,9 @@ static HB_ERRCODE sddDisconnect( SQLDDCONNECTION * pConnection );
|
||||
static HB_ERRCODE sddExecute( SQLDDCONNECTION * pConnection, PHB_ITEM pItem );
|
||||
static HB_ERRCODE sddOpen( SQLBASEAREAP pArea );
|
||||
static HB_ERRCODE sddClose( SQLBASEAREAP pArea );
|
||||
static HB_ERRCODE sddGoTo( SQLBASEAREAP pArea, ULONG ulRecNo );
|
||||
static HB_ERRCODE sddGoTo( SQLBASEAREAP pArea, HB_ULONG ulRecNo );
|
||||
static HB_ERRCODE sddGetValue( SQLBASEAREAP pArea, HB_USHORT uiIndex, PHB_ITEM pItem );
|
||||
static HB_ERRCODE sddGetVarLen( SQLBASEAREAP pArea, HB_USHORT uiIndex, ULONG * pLength );
|
||||
static HB_ERRCODE sddGetVarLen( SQLBASEAREAP pArea, HB_USHORT uiIndex, HB_ULONG * pLength );
|
||||
|
||||
|
||||
static SDDNODE sddNull = {
|
||||
@@ -186,7 +186,7 @@ static HB_ERRCODE sddClose( SQLBASEAREAP pArea )
|
||||
}
|
||||
|
||||
|
||||
static HB_ERRCODE sddGoTo( SQLBASEAREAP pArea, ULONG ulRecNo )
|
||||
static HB_ERRCODE sddGoTo( SQLBASEAREAP pArea, HB_ULONG ulRecNo )
|
||||
{
|
||||
if ( ulRecNo == 0 || ulRecNo > pArea->ulRecCount )
|
||||
{
|
||||
@@ -216,7 +216,7 @@ static HB_ERRCODE sddGetValue( SQLBASEAREAP pArea, HB_USHORT uiIndex, PHB_ITEM p
|
||||
}
|
||||
|
||||
|
||||
static HB_ERRCODE sddGetVarLen( SQLBASEAREAP pArea, HB_USHORT uiIndex, ULONG * pLength )
|
||||
static HB_ERRCODE sddGetVarLen( SQLBASEAREAP pArea, HB_USHORT uiIndex, HB_ULONG * pLength )
|
||||
{
|
||||
HB_SYMBOL_UNUSED( pArea );
|
||||
HB_SYMBOL_UNUSED( uiIndex );
|
||||
@@ -273,7 +273,7 @@ static HB_ERRCODE sqlbaseGoBottom( SQLBASEAREAP pArea )
|
||||
return HB_FAILURE;
|
||||
|
||||
|
||||
if ( ! pArea->fFetched && pArea->pSDD->GoTo( pArea, ( ULONG ) -1 ) == HB_FAILURE )
|
||||
if ( ! pArea->fFetched && pArea->pSDD->GoTo( pArea, ( HB_ULONG ) -1 ) == HB_FAILURE )
|
||||
return HB_FAILURE;
|
||||
|
||||
pArea->area.fTop = HB_FALSE;
|
||||
@@ -286,7 +286,7 @@ static HB_ERRCODE sqlbaseGoBottom( SQLBASEAREAP pArea )
|
||||
}
|
||||
|
||||
|
||||
static HB_ERRCODE sqlbaseGoTo( SQLBASEAREAP pArea, ULONG ulRecNo )
|
||||
static HB_ERRCODE sqlbaseGoTo( SQLBASEAREAP pArea, HB_ULONG ulRecNo )
|
||||
{
|
||||
if ( SELF_GOCOLD( ( AREAP ) pArea ) == HB_FAILURE )
|
||||
return HB_FAILURE;
|
||||
@@ -400,7 +400,7 @@ static HB_ERRCODE sqlbaseSkipRaw( SQLBASEAREAP pArea, HB_LONG lToSkip )
|
||||
pArea->area.fBof = bBof;
|
||||
pArea->area.fEof = bEof;
|
||||
}
|
||||
else if ( lToSkip < 0 && ( ULONG ) ( -lToSkip ) >= pArea->ulRecNo )
|
||||
else if ( lToSkip < 0 && ( HB_ULONG ) ( -lToSkip ) >= pArea->ulRecNo )
|
||||
{
|
||||
errCode = SELF_GOTO( ( AREAP ) pArea, 1 );
|
||||
pArea->area.fBof = HB_TRUE;
|
||||
@@ -471,7 +471,7 @@ static HB_ERRCODE sqlbaseGetValue( SQLBASEAREAP pArea, HB_USHORT uiIndex, PHB_IT
|
||||
}
|
||||
|
||||
|
||||
static HB_ERRCODE sqlbaseGetVarLen( SQLBASEAREAP pArea, HB_USHORT uiIndex, ULONG * pLength )
|
||||
static HB_ERRCODE sqlbaseGetVarLen( SQLBASEAREAP pArea, HB_USHORT uiIndex, HB_ULONG * pLength )
|
||||
{
|
||||
/* TODO: should we use this code?
|
||||
if ( pArea->area.lpFields[ uiIndex ].uiType == HB_IT_MEMO )
|
||||
@@ -576,14 +576,14 @@ static HB_ERRCODE sqlbaseRecall( SQLBASEAREAP pArea )
|
||||
}
|
||||
|
||||
|
||||
static HB_ERRCODE sqlbaseRecCount( SQLBASEAREAP pArea, ULONG * pRecCount )
|
||||
static HB_ERRCODE sqlbaseRecCount( SQLBASEAREAP pArea, HB_ULONG * pRecCount )
|
||||
{
|
||||
* pRecCount = pArea->ulRecCount;
|
||||
return HB_SUCCESS;
|
||||
}
|
||||
|
||||
|
||||
static HB_ERRCODE sqlbaseRecNo( SQLBASEAREAP pArea, ULONG * ulRecNo )
|
||||
static HB_ERRCODE sqlbaseRecNo( SQLBASEAREAP pArea, HB_ULONG * ulRecNo )
|
||||
{
|
||||
* ulRecNo = pArea->ulRecNo;
|
||||
return HB_SUCCESS;
|
||||
@@ -593,7 +593,7 @@ static HB_ERRCODE sqlbaseRecNo( SQLBASEAREAP pArea, ULONG * ulRecNo )
|
||||
static HB_ERRCODE sqlbaseRecId( SQLBASEAREAP pArea, PHB_ITEM pRecNo )
|
||||
{
|
||||
HB_ERRCODE errCode;
|
||||
ULONG ulRecNo;
|
||||
HB_ULONG ulRecNo;
|
||||
|
||||
errCode = SELF_RECNO( ( AREAP ) pArea, &ulRecNo );
|
||||
hb_itemPutNInt( pRecNo, ulRecNo );
|
||||
@@ -613,7 +613,7 @@ static HB_ERRCODE sqlbaseClose( SQLBASEAREAP pArea )
|
||||
|
||||
if ( pArea->pRow )
|
||||
{
|
||||
ULONG ulIndex;
|
||||
HB_ULONG ulIndex;
|
||||
|
||||
for ( ulIndex = 0; ulIndex <= pArea->ulRecCount; ulIndex++ )
|
||||
{
|
||||
@@ -902,7 +902,7 @@ static HB_ERRCODE sqlbaseInit( LPRDDNODE pRDD )
|
||||
|
||||
static HB_ERRCODE sqlbaseExit( LPRDDNODE pRDD )
|
||||
{
|
||||
ULONG ul;
|
||||
HB_ULONG ul;
|
||||
|
||||
HB_SYMBOL_UNUSED( pRDD );
|
||||
|
||||
@@ -938,10 +938,10 @@ static HB_ERRCODE sqlbaseExit( LPRDDNODE pRDD )
|
||||
}
|
||||
|
||||
|
||||
static HB_ERRCODE sqlbaseRddInfo( LPRDDNODE pRDD, HB_USHORT uiIndex, ULONG ulConnect, PHB_ITEM pItem )
|
||||
static HB_ERRCODE sqlbaseRddInfo( LPRDDNODE pRDD, HB_USHORT uiIndex, HB_ULONG ulConnect, PHB_ITEM pItem )
|
||||
{
|
||||
ULONG ulConn;
|
||||
SQLDDCONNECTION* pConn;
|
||||
HB_ULONG ulConn;
|
||||
SQLDDCONNECTION * pConn;
|
||||
|
||||
HB_SYMBOL_UNUSED( pRDD );
|
||||
|
||||
@@ -960,7 +960,7 @@ static HB_ERRCODE sqlbaseRddInfo( LPRDDNODE pRDD, HB_USHORT uiIndex, ULONG ulCon
|
||||
|
||||
case RDDI_CONNECTION:
|
||||
{
|
||||
ULONG ulNewConnection = 0;
|
||||
HB_ULONG ulNewConnection = 0;
|
||||
|
||||
if ( hb_itemType( pItem ) & HB_IT_NUMERIC )
|
||||
{
|
||||
@@ -985,9 +985,9 @@ static HB_ERRCODE sqlbaseRddInfo( LPRDDNODE pRDD, HB_USHORT uiIndex, ULONG ulCon
|
||||
|
||||
case RDDI_CONNECT:
|
||||
{
|
||||
PSDDNODE pNode = NULL;
|
||||
ULONG ul;
|
||||
const char* pStr;
|
||||
PSDDNODE pNode = NULL;
|
||||
HB_ULONG ul;
|
||||
const char * pStr;
|
||||
|
||||
/* Find free connection handle */
|
||||
for ( ul = 0; ul < s_ulConnectionCount; ul++ )
|
||||
|
||||
Reference in New Issue
Block a user