20000408-14:38 DST

harbour/ChangeLog

@@ -1,3 +1,8 @@
+20000408-14:38 DST Paul Tucker <ptucker@sympatico.ca>
+   * source/rtl/strcase.c
+     * some compilers impliment toupper() as a macro, so toupper( pSrc++ )
+     * does not work properly.
+
 20000408-20:45 GMT+1 Ryszard Glab <rglab@imid.med.pl>
 
     *source/rtl/gtcrs/gtcrs.c

harbour/source/rtl/strcase.c

@@ -69,15 +69,17 @@ char * hb_strUpper( char * szText, ULONG ulLen )
  */
 char * hb_strncpyUpper( char * pDest, const char * pSource, ULONG ulLen )
 {
-   char * pStart = pDest;
-
    HB_TRACE(HB_TR_DEBUG, ("hb_strncpyUpper(%p, %s, %lu)", pDest, pSource, ulLen));
 
    pDest[ ulLen ] ='\0';
    while( ulLen-- )
-      *pDest++ = toupper( *pSource++ );
+   {
+      /* some compilers impliment toupper as a macro, and this has side effects! */
+      /* *pDest++ = toupper( *pSource++ ); */
+      pDest[ulLen] = toupper( pSource[ulLen] );
+   }
 
-   return pStart;
+   return pDest;
 }
 
 /* converts string to lower case */