19990925-05:57 GMT+1

harbour/ChangeLog

@@ -1,3 +1,10 @@
+19990925-05:57 GMT+1 Victor Szel <info@szelvesz.hu>
+  * source/vm/dynsym.c
+    ! HB___DYNSGETNAME() now validates the index parameter passed.
+      Previously it could GPF with 0 or too big index.
+  * tests/working/dynsym.prg
+    + Some new lines added to test the situations above.
+
 19990924-23:10 EDT Paul Tucker <ptucker@sympatico.ca>
   * source/vm/dynsym.c
     * corrected return value of HB___DYNSGETINDEX()

harbour/source/vm/dynsym.c

@@ -258,7 +258,12 @@ HARBOUR HB___DYNSCOUNT( void ) /* How much symbols do we have: dsCount = __dynsy
 
 HARBOUR HB___DYNSGETNAME( void ) /* Get name of symbol: cSymbol = __dynsymGetName( dsIndex ) */
 {
-   hb_retc( s_pDynItems[ hb_parnl( 1 ) - 1 ].pDynSym->pSymbol->szName );
+   LONG lIndex = hb_parnl( 1 ); /* NOTE: This will return zero if the parameter is not numeric */
+
+   if( lIndex >= 1 && lIndex <= s_uiDynSymbols )
+      hb_retc( s_pDynItems[ lIndex - 1 ].pDynSym->pSymbol->szName );
+   else
+      hb_retc( "" );
 }
 
 HARBOUR HB___DYNSGETINDEX( void ) /* Gimme index number of symbol: dsIndex = __dynsymGetIndex( cSymbol ) */
@@ -269,5 +274,5 @@ HARBOUR HB___DYNSGETINDEX( void ) /* Gimme index number of symbol: dsIndex = __d
       hb_retnl( ( LONG ) ( s_uiClosestDynSym + 1 ) );
    else
       hb_retnl( 0L );
-
 }
+

harbour/tests/working/dynsym.prg

@@ -14,5 +14,9 @@ FUNCTION Main()
    ? "MAIN", nPos
 
    ? __dynsGetName( nPos )
+   ? __dynsGetName()
+   ? __dynsGetName( 0 )
+   ? __dynsGetName( 100000 )
+   ? __dynsGetName( __dynsGetIndex( "HB_THISDOESNTEXIST_" ) )
    
    RETURN NIL