fivedev/harbour-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

2011-02-09 21:23 UTC+0100 Przemyslaw Czerpak (druzus/at/priv.onet.pl)

Browse Source 
* harbour/contrib/hbwin/axcore.c
    ! fixed double binding of ax event handler with two different
      OLE pointer items - it was causing accessing freed or reused
      by other things memory potentially with all possible bad side
      effect.
      Mindaugas, please verify me but I think that you forgot to remove
      the old binding when you were adding the code I proposed and you
      didn't leave it intentionally. Am I right?
This commit is contained in:
Przemyslaw Czerpak
2011-02-09 20:23:43 +00:00
parent 824c86f7e6
commit d2ad59df66
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
harbour/ChangeLog
View File

@@ -16,6 +16,16 @@
The license applies to all entries newer than 2009-04-28.
*/
2011-02-09 21:23 UTC+0100 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
* harbour/contrib/hbwin/axcore.c
! fixed double binding of ax event handler with two different
OLE pointer items - it was causing accessing freed or reused
by other things memory potentially with all possible bad side
effect.
Mindaugas, please verify me but I think that you forgot to remove
the old binding when you were adding the code I proposed and you
didn't leave it intentionally. Am I right?
2011-02-09 16:56 UTC+0100 Viktor Szakats (harbour.01 syenar.hu)
* contrib/hbmysql/hbmysql.hbc
* contrib/hbct/hbct.hbc

2
harbour/contrib/hbwin/axcore.c
View File

@@ -655,8 +655,6 @@ HB_FUNC( __AXREGISTERHANDLER ) /* ( pDisp, bHandler [, cIID] ) --> pSink */
pSink->lpVtbl = ( IDispatchVtbl * ) &ISink_Vtbl;
pSink->count = 0;
pSink->pItemHandler = hb_itemNew( pItemBlock );
hb_oleItemSetCallBack( hb_param( 1, HB_IT_POINTER ),
&pSink->pItemHandler );
pSink->rriid = rriid;
pSink->uiClass = 0;
lOleError = HB_VTBL( pCP )->Advise( HB_THIS_( pCP ) ( IUnknown* ) pSink, &dwCookie );